refactor(retrofit2): replace retrofit client with retrofit2 client #6340
+933
−733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirangodishala
requested review from
jeyrschabu,
ajordens,
cfieber,
zachsmith1,
plumpy,
skandragon,
clanesf and
german-muzquiz
as code owners
kirangodishala
force-pushed
the
retrofit2-upgrade
branch
from
9f14d87 to
a5ed6b0
Compare
dzhengg
reviewed
Jan 30, 2025
...etflix/spinnaker/clouddriver/docker/registry/api/v2/auth/DockerBearerTokenServiceSpec.groovy
Outdated
Show resolved
Hide resolved
| getDigestContent(_,_,_,_) >> contentDigestResponse | ||
| // TypedInput configDigestContentInput = new TypedByteArray("application/json", configDigestContentJson.getBytes()) | ||
| Response contentDigestResponse = Response.success(200, ResponseBody.create(MediaType.parse("application/json"), configDigestContentJson)) | ||
| // Response contentDigestResponse = new Response("/v2/{repository}/blobs/{digest}",200, "nothing", Collections.EMPTY_LIST, configDigestContentInput) |
There was a problem hiding this comment.
Some more commented-out code in this file
…ents from retrofit to retrofit2
kirangodishala
force-pushed
the
retrofit2-upgrade
branch
from
3c25b80 to
5ccbffa
Compare
dbyron-sf
approved these changes
Feb 3, 2025
kirangodishala
added a commit
to kirangodishala/spinnaker.io
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of retrofit 2.x client in place of retrofit 1.9 and make required changes accordingly.
All the retrofit1 dependencies and references are removed.
Retrofit2 boilerplate code was already implemented in kork's kork-retrofit module and this PR makes use of it.